test(source/cloudsqlpg): create MCP integration tests#2994
Open
anubhav756 wants to merge 16 commits intoanubhav-mcp-alloydbpgfrom
Open
test(source/cloudsqlpg): create MCP integration tests#2994anubhav756 wants to merge 16 commits intoanubhav-mcp-alloydbpgfrom
anubhav756 wants to merge 16 commits intoanubhav-mcp-alloydbpgfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds integration tests for the Cloud SQL Postgres data source, including tests for listing and calling tools. The review identifies several improvement opportunities: refactoring the connection pool setup to eliminate code duplication and use production logic, enhancing environment variable validation to report all missing variables simultaneously, and renaming validation functions to better reflect their purpose while ensuring consistent application across test cases.
75f859a to
c4a9912
Compare
59c2b6a to
2be51dc
Compare
5849570 to
274ee95
Compare
2be51dc to
5561185
Compare
4323012 to
4b94c00
Compare
e120bc5 to
e74fd80
Compare
4b94c00 to
2f96090
Compare
7011296 to
29a4b31
Compare
7b71b7d to
9a3ebe7
Compare
aa1537c to
9534b6d
Compare
f30ecae to
3fe7c26
Compare
9534b6d to
7e2f851
Compare
3fe7c26 to
e9fbe85
Compare
7e2f851 to
e327a2c
Compare
aad6cd9 to
9ecd5c2
Compare
7515be5 to
b92c4a2
Compare
9ecd5c2 to
cf13215
Compare
b92c4a2 to
05e1161
Compare
cf13215 to
63b7b9e
Compare
7bb67bb to
1189409
Compare
… GetMCPResultText
63b7b9e to
85a2173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the mapped integration tests for CloudSQL PG tools using the native MCP harness.